This repository was archived by the owner on Aug 20, 2019. It is now read-only.
Add/setting source name #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Millicom asked us to add a custom "segment_source_name" property to our client and serverside Mixpanel integrations. Today, this feature only works for the server-side Mixpanel integration.
The changes introduced will support sending a property called
segment_source_nameto Mixpanel on a Segmenttrackevent when a user has the settingsourceNameconfigured with a value in Segment's UI. This brings the client and server-side Mixpanel integrations to parity with regards to this setting.Tested locally with golden-compiler
Steps taken:
npm install -g @segment/golden-compilersourceName, in this case I addedmy_source.golden-ajs --settings= ./settings.json --slug=mixpanel --write-key=<WRITE_KEY>trackcallsource_nameappear in Mixpanel's UI as a propertyJIRA ticket: https://segment.atlassian.net/browse/ENT-97
CC ticket: https://segment.atlassian.net/browse/CC-922
Note: The sauce lab keys are removed here because the ENV variables are respected and set via Circle CI's UI, not the circle.yml. In addition to this, we should not put credentials in open sourced repos. Confirmed that these credentials removed are expired and no longer used in production.