-
Couldn't load subscription status.
- Fork 0
feat: ✨ add Commitizen version bump with GitHub workflow #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Let's see how it goes 🤞
…ata-package into feat/add-release-workflow
…ata-package into feat/add-release-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mini suggestions ✏️
|
Unrelated to the changes here, the test check fails ⬆️ |
|
Yea, I'm trying to fix it 🤔 |
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
Description
Adding auto-version update workflow via Commitizen. Right now though, I don't know if the
version_fileswill work though, since it is basic "search and replace for version number in the given files". Thedatapackage.jsonfile will/may have twoversionfields, one in the top level and another in thesourceslevel. So this might also bump those versions too (like we had an issue with in Sprout). So we'll have to see how it goes.Closes #51
Closes #55
This PR needs a quick review.