refactor: ♻️ match Sprout #40
Conversation
| To add uv: | ||
|
|
||
| 1. Delete the `pyproject.toml` file. | ||
| 2. In the terminal run `uv init`. | ||
| 3. Look at the Git pane and take what was removed and move it over into | ||
| 1. Delete the `pyproject.toml` file. | ||
| 2. In the terminal run `uv init`. | ||
| 3. Look at the Git pane and take what was removed and move it over into | ||
| the new `pyproject.toml` file. You can mimic what was done in | ||
| `example-seed-beetle` repo. | ||
|
|
||
| Then, in the terminal, run: | ||
|
|
||
| ``` bash | ||
| uv add polars pyjanitor | ||
| uv add "seedcase-sprout @ git+<https://github.com/seedcase-project/seedcase-sprout>" | ||
| uv add seedcase-sprout@git+https://github.com/seedcase-project/seedcase-sprout | ||
| uv add --dev ruff commitizen pre-commit typos | ||
| ``` |
There was a problem hiding this comment.
As the pyproject.toml file is already set up, could we not just run uv sync?
There was a problem hiding this comment.
True. Though we'll very soon need to set the pypi version of Sprout, not the GitHub version. That's something you can do here.
main.py
Outdated
| # Write properties from properties script to `datapackage.json`. | ||
| # sp.write_properties(properties=properties) |
There was a problem hiding this comment.
Could also add the resources bit commented out?
There was a problem hiding this comment.
There's a lot more that can be added here, based on what is in Sprout's guide.
There was a problem hiding this comment.
Ah okay! I didn't know whether the intention was to include as much of the guide or not
| To add uv: | ||
|
|
||
| 1. Delete the `pyproject.toml` file. | ||
| 2. In the terminal run `uv init`. | ||
| 3. Look at the Git pane and take what was removed and move it over into | ||
| 1. Delete the `pyproject.toml` file. | ||
| 2. In the terminal run `uv init`. | ||
| 3. Look at the Git pane and take what was removed and move it over into | ||
| the new `pyproject.toml` file. You can mimic what was done in | ||
| `example-seed-beetle` repo. | ||
|
|
||
| Then, in the terminal, run: | ||
|
|
||
| ``` bash | ||
| uv add polars pyjanitor | ||
| uv add "seedcase-sprout @ git+<https://github.com/seedcase-project/seedcase-sprout>" | ||
| uv add seedcase-sprout@git+https://github.com/seedcase-project/seedcase-sprout | ||
| uv add --dev ruff commitizen pre-commit typos | ||
| ``` |
There was a problem hiding this comment.
True. Though we'll very soon need to set the pypi version of Sprout, not the GitHub version. That's something you can do here.
main.py
Outdated
| # Write properties from properties script to `datapackage.json`. | ||
| # sp.write_properties(properties=properties) |
There was a problem hiding this comment.
There's a lot more that can be added here, based on what is in Sprout's guide.
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
There was a problem hiding this comment.
I assumed this was a hangover and deleted it
| # from scripts.resource_properties import resource_properties | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
This should be the full script. You can't just uncomment and run everything at once because required properties need to be filled in, scripts/resource_properties.py needs to be created, etc.
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
2 participants
Description
This PR:
uv cache cleanto make it pull the newest one)main.pyIs there anything else to do to make the template match Sprout? Sorry if I completely misunderstood it, but it feels like it's ready to use the latest version of Sprout.
I could add
mypy?Closes #29, closes #33
This PR needs a quick review.
Checklist
just run-all