refactor: 🚚 rename obj in package properties script to package_properties
#1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
changed the title
package_propertiespackage_properties
martonvago
previously approved these changes
Jul 23, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
|
Yes! On it :) |
`properties.py` -> `package_properties.py`; `properties` -> `package_properties` within code blocks.
lwjohnst86
approved these changes
Jul 23, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
lwjohnst86
deleted the
refactor/rename-properties-obj-in-package-properties-script
branch
github-project-automation
bot
moved this from In Progress
to Done
in Iteration planning
2 tasks
lwjohnst86
pushed a commit
to seedcase-project/template-data-package
that referenced
this pull request
Jul 28, 2025
# Description This PR renames `properties` to `package_properties` to match what was done in seedcase-project/seedcase-sprout#1484. This PR needs a quick review. ## Checklist - [x] Formatted Markdown - [x] Ran `just run-all`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I renamed the template, I forgot to rename the
PackagePropertiesobject in it to match. This PR does that.This PR needs a quick review.
Checklist
just run-all