refactor: ♻️ rename check() arg from descriptor to properties
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
commented
Oct 17, 2025
| @@ -1,36 +1,43 @@ | |||
| --- | |||
| title: "Checking a Data Package descriptor" | |||
| title: "Checking a Data Package's properties" | |||
There was a problem hiding this comment.
We could also use "metadata" here, as I've done on the landing page now #141
There was a problem hiding this comment.
I've started to wonder if we can stop using the word "descriptor" entirely, using either metadata or datapackage.json instead (whichever is appropriate in the context) when talking about the JSON file and then properties otherwise. What do you think?
There was a problem hiding this comment.
I'm ok with that 👍 simpler, clearer, plainer language is something I always appreciate!! 😁
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
lwjohnst86
deleted the
refactor/rename-check-arg-from-descriptor-to-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Again following that we've agreed to use the word "properties" about the descriptor's content loaded as a
dict.Related to #104
Needs an in-depth review.
Checklist
just run-all