Skip to content

Conversation

@martonvago
Copy link
Contributor

Description

I thought there were so many "check"s around, and this method actually checks the value of a field, not the descriptor/properties.

Needs a quick review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@martonvago martonvago self-assigned this Oct 17, 2025
@martonvago martonvago moved this from Todo to In Review in Iteration planning Oct 17, 2025
@martonvago martonvago marked this pull request as ready for review October 17, 2025 11:19
@martonvago martonvago requested a review from a team as a code owner October 17, 2025 11:19
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine with me. Though, what do you think of something like condition instead of check_value?

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Oct 17, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't mind it being "check" here, bc it's the actual check that the custom check will perform, right? :)

@martonvago
Copy link
Contributor Author

This works fine with me. Though, what do you think of something like condition instead of check_value?

I like it!

@martonvago
Copy link
Contributor Author

Hmm, I guess I'll hold off on this until we decide what to do with required checks.

@martonvago martonvago marked this pull request as draft October 20, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants