This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Publish Docker Images in regular Docker group #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the release of version 2 of the SecureCodeBox we want to move the used Docker images from the experimental group to the regular group To make this possible I changed the docker group in the CI using VIMs search and replace (`:%s/scbexperimental/securecodebox/g`) To make sure that every reference (e.g. in helm charts) is updated I searched for all occurence using ripgrep (`rg -il "scbexperimental" ./`)
nigthknight
requested review from
J12934 and
rseedorff
and removed request for
J12934
nigthknight
force-pushed
the
update-docker-image-group
branch
from
9139137 to
ba0e0f5
Compare
To make it possible to change the docker images for scanners and hooks via values.xml I updated the following charts: - kube-hunter - ncrack - nikto - nmap - test-scan This is necessary for these charts because we do not use the official images for these scanners/hooks and cannot rely on their image tags
J12934
suggested changes
Sep 29, 2020
J12934
suggested changes
Sep 30, 2020
J12934
approved these changes
Oct 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applied this PR will:
scbexperimentalgroup to regularsecurecodeboxscbexperimentalimages tosecurecodeboximagescloses #102