DHCP_am: support multiple nameservers

[gpotter2]

• rework of Fix #4431 - Allow DHCP Answering Machine to have multiple namesevers #4638 with doc and a simpler API

closes #4638
fixes #4431

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.50%. Comparing base (c7aa3e9) to head (7711b1f).

Files with missing lines	Patch %	Lines
scapy/layers/dhcp.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4834      +/-   ##
==========================================
- Coverage   80.88%   80.50%   -0.38%     
==========================================
  Files         368      368              
  Lines       90231    90236       +5     
==========================================
- Hits        72980    72643     -337     
- Misses      17251    17593     +342     

Files with missing lines	Coverage Δ
scapy/layers/dhcp.py	82.81% <83.33%> (-0.05%)	⬇️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[evverx]

Looks like it fails on Fedora Rawhide (with Python 3.14.0rc2):

###(006)=[failed] Check that the dhcpd alias is properly defined and documented

>>> assert dhcpd
>>> import IPython
>>> 
>>> result = IPython.lib.pretty.pretty(dhcpd)
>>> result
'<function scapy.ansmachine.dhcpd(self, pool: scapy.base_classes.Net | List[str] = Net("192.168.1.128/25"), network: str = \'192.168.1.0/24\', gw: str = \'192.168.1.1\', nameserver: str | List[str] = None, domain: str | None = None, renewal_time: int = 60, lease_time: int = 1800, **kwargs)>'
>>> 
>>> assert result in [
...     '<function scapy.ansmachine.dhcpd(self, pool: Union[scapy.base_classes.Net, List[str]] = Net("192.168.1.128/25"), network: str = \'192.168.1.0/24\', gw: str = \'192.168.1.1\', nameserver: Union[str, List[str]] = None, domain: Optional[str] = None, renewal_time: int = 60, lease_time: int = 1800, **kwargs)>',
...     '<function scapy.ansmachine.dhcpd(self, pool: Union[scapy.base_classes.Net, List[str]] = Net("192.168.1.128/25"), network: str = \'192.168.1.0/24\', gw: str = \'192.168.1.1\', nameserver: Union[str, List[str]] = None, domain: Union[str, NoneType] = None, renewal_time: int = 60, lease_time: int = 1800, **kwargs)>',
...     '<function scapy.ansmachine.dhcpd(self, pool=Net("192.168.1.128/25"), network=\'192.168.1.0/24\', gw=\'192.168.1.1\', nameserver=None, domain=None, renewal_time=60, lease_time=1800, **kwargs)>',
... ]
AssertionError

https://download.copr.fedorainfracloud.org/results/packit/evverx-scapy-2/fedora-rawhide-aarch64/09564744-scapy/builder-live.log.gz

[gpotter2]

Thanks ! See befe516

This varies a LOT depending on the Python version hehe ^^