Skip to content

Conversation

guedou
Copy link
Member

@guedou guedou commented Dec 5, 2022

This PR adds fixes for FreeBSD, OpenBSD and NetBSD.

It fixes #3721.

@guedou guedou added this to the 2.5.0 milestone Dec 5, 2022
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ! Awesome work !!

then
# Note: LibreSSL 3.6.* does not support X25519 according to
# the cryptogaphy module source code
UT_FLAGS+=" -K libressl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that in UTscapy, tags are expected to indicate what the test works on rather that what it doesn't work on :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be, these flags are used to tag features, and later on kill them with -K or a config file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call.

@gpotter2 gpotter2 merged commit 6a4f0db into master Dec 6, 2022
@gpotter2 gpotter2 deleted the bsd_fixes branch December 6, 2022 22:22
alxroyer-thales pushed a commit to ThalesGroup/scapy that referenced this pull request Jun 27, 2025
* FreeBSD - /dev/bpf cannot send packets to /dev/tun* and /dev/tap*

* FreeBSD - unit test fixes

* OpenBSD - unit test fixes

* NetBSD - unit test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failing on OpenBSD 7.1
2 participants