-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
btle: Add definitions for Bluetooth 5.0 control PDUs #3037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3037 +/- ##
==========================================
- Coverage 85.37% 85.36% -0.01%
==========================================
Files 255 256 +1
Lines 53971 54113 +142
==========================================
+ Hits 46076 46196 +120
- Misses 7895 7917 +22
|
@rugeGerritsen thanks a lot. Dissection may be implemented after adding scapy/scapy/layers/bluetooth4LE.py Lines 362 to 363 in 962a95a
I couldn't confirm this at the time so feel free to try this out. |
The changes only support using scapy as a packet builder. Dissection is not yet implemented. Co-authored-by: Rubin Gerritsen <[email protected]>
aaafacf
to
9350d16
Compare
@Matheus-Garbelini , thanks for your feedback. I will leave the dissection as is for now. The last push only initializes the base class of
I'm familiar enough with pylint to understand what is wrong here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from two minor cosmetic comments (that you can probably ignore), this LGTM !
Thanks for the PR
@gpotter2 , thanks for your review! |
* btle: Add definitions for Bluetooth 5.0 control PDUs The changes only support using scapy as a packet builder. Dissection is not yet implemented. Co-authored-by: Rubin Gerritsen <[email protected]> * Minor cosmetics changes Co-authored-by: Matheus Garbelini <[email protected]> Co-authored-by: Gabriel <[email protected]>
* btle: Add definitions for Bluetooth 5.0 control PDUs The changes only support using scapy as a packet builder. Dissection is not yet implemented. Co-authored-by: Rubin Gerritsen <[email protected]> * Minor cosmetics changes Co-authored-by: Matheus Garbelini <[email protected]> Co-authored-by: Gabriel <[email protected]>
The changes only support using scapy as a packet builder.
Dissection is not yet implemented.
I've used #2215 by @Matheus-Garbelini as a starting point.
closes #2215