Advanced cryptogaphy comment #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2619 +/- ##
==========================================
- Coverage 88.61% 88.56% -0.05%
==========================================
Files 247 247
Lines 52053 52057 +4
==========================================
- Hits 46125 46104 -21
- Misses 5928 5953 +25
|
gpotter2
reviewed
Apr 30, 2020
scapy/config.py
Outdated
| """ | ||
| Check if the cryptography library is present, and if it is recent enough | ||
| for most usages in scapy (v1.7 or later). | ||
| Check if the cryptography module >= 1.7 is present. This is the minimum |
There was a problem hiding this comment.
Actually we've dropped <2.0.0
b658909
The PR was using some >2.0.0 only things.
There was a problem hiding this comment.
What should I do? Remove this function?
There was a problem hiding this comment.
The function still checks if cryptography is present. We could issue a warning if the version is < 2.0.0 (and update it to return True only when > 2.0.0)
p-l-
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2398