Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 added the tls label Apr 11, 2020
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #2585 into master will decrease coverage by 0.30%.
The diff coverage is 73.63%.

@@            Coverage Diff             @@
##           master    #2585      +/-   ##
==========================================
- Coverage   88.49%   88.18%   -0.31%     
==========================================
  Files         246      246              
  Lines       51895    52003     +108     
==========================================
- Hits        45922    45858      -64     
- Misses       5973     6145     +172     
Impacted Files Coverage Δ
scapy/layers/tls/record.py 90.80% <0.00%> (+0.34%) ⬆️
scapy/layers/tls/automaton_cli.py 82.67% <62.16%> (-1.10%) ⬇️
scapy/layers/tls/automaton_srv.py 78.03% <76.36%> (-0.13%) ⬇️
scapy/automaton.py 88.00% <100.00%> (+0.13%) ⬆️
scapy/layers/tls/handshake.py 87.29% <100.00%> (+0.97%) ⬆️
scapy/layers/tls/keyexchange.py 81.79% <100.00%> (-0.21%) ⬇️
scapy/layers/tls/record_tls13.py 86.25% <100.00%> (+2.92%) ⬆️
scapy/contrib/automotive/obd/scanner.py 6.74% <0.00%> (-89.89%) ⬇️
scapy/contrib/cansocket.py 70.83% <0.00%> (-8.34%) ⬇️
scapy/contrib/isotp.py 85.98% <0.00%> (-5.58%) ⬇️
... and 22 more

@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-auth branch from 2d2c237 to 7e3bb08 Compare April 11, 2020 17:23
@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-auth branch from 7e3bb08 to 38a2b76 Compare April 11, 2020 17:42
@gpotter2
Copy link
Member Author

gpotter2 commented Apr 11, 2020

Tests don't pass on travis because it uses OpenSSL 1.0.2g which doesn't support tls 1.3 (it needs OpenSSL 1.1.1).

I'll pin Ubuntu Bionic on travis

@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-auth branch 3 times, most recently from d6daacc to 2309916 Compare April 11, 2020 22:06
@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-auth branch from 2309916 to 7782e0f Compare April 11, 2020 22:19
@gpotter2
Copy link
Member Author

@guedou @p-l- Ready for review

Copy link
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! I made some comments, most are cosmetic.

@guedou guedou merged commit 2b7a431 into secdev:master Apr 17, 2020
@romain-perez romain-perez mentioned this pull request Apr 30, 2020
9 tasks
@gpotter2 gpotter2 deleted the romain-perez-add-tls13-client-auth branch April 30, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants