- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.2k
[TLS13] Add client auth #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TLS13] Add client auth #2585
Conversation
         gpotter2
  
      
      
      commented
      
            gpotter2
  
      
      
      commented
        Apr 11, 2020 
      
    
  
- rebase of https://github.com/romain-perez/scapy/tree/add-tls13-client-auth
- PR finished
- unit tests added
| Codecov Report
 @@            Coverage Diff             @@
##           master    #2585      +/-   ##
==========================================
- Coverage   88.49%   88.18%   -0.31%     
==========================================
  Files         246      246              
  Lines       51895    52003     +108     
==========================================
- Hits        45922    45858      -64     
- Misses       5973     6145     +172     
 | 
2d2c237    to
    7e3bb08      
    Compare
  
    7e3bb08    to
    38a2b76      
    Compare
  
    | Tests don't pass on travis because it uses  I'll pin Ubuntu Bionic on travis | 
d6daacc    to
    2309916      
    Compare
  
    2309916    to
    7782e0f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! I made some comments, most are cosmetic.