Accept Scapy Packets as offline inputs #2101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpotter2
reviewed
Jun 24, 2019
guedou
force-pushed
the
issue_1929_packets
branch
from
395a742 to
6969893
Compare
gpotter2
previously approved these changes
Jun 24, 2019
guedou
force-pushed
the
issue_1929_packets
branch
2 times, most recently
from
121e030 to
e421169
Compare
Codecov Report
@@ Coverage Diff @@
## master #2101 +/- ##
==========================================
- Coverage 87.18% 86.47% -0.71%
==========================================
Files 197 197
Lines 44486 44495 +9
==========================================
- Hits 38787 38479 -308
- Misses 5699 6016 +317
|
guedou
force-pushed
the
issue_1929_packets
branch
from
e421169 to
fb037a0
Compare
|
@gpotter2 ready to be reviewed and merged. |
gpotter2
reviewed
Jun 26, 2019
scapy/sendrecv.py
Outdated
There was a problem hiding this comment.
I wonder if we don't want to use scapy.utils.get_temp_file(autoext=".pcap") instead
gpotter2
previously approved these changes
Jun 26, 2019
guedou
force-pushed
the
issue_1929_packets
branch
from
fb037a0 to
5385885
Compare
gpotter2
reviewed
Jun 27, 2019
guedou
force-pushed
the
issue_1929_packets
branch
from
5385885 to
59f2fb1
Compare
gpotter2
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1929.
The original
sniff()was not supposed to work this way. However, I find it quite useful to be able to build packets with Scapy and filter them withtcpdump. This a great way to test BPF filters.I am no 100% happy with the current implementation but it seems to work fine.