-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
DNS cleanup & various cleanups #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 85.87% 80.51% -5.36%
==========================================
Files 187 132 -55
Lines 43010 31277 -11733
==========================================
- Hits 36933 25182 -11751
- Misses 6077 6095 +18
|
044c058
to
458a2fe
Compare
One more remark:
i.e. no decompression is done when showing the result of dns_compress, while it is done when constructing of from a raw packet. That was already the case before this patch, though. I just mention this because it might also be fixable by playing with any2i. |
That’s expected. Performing |
Could we get #1849 merged before I start conflicting with it ? Thanks ! |
@gpotter2 yep, done. Sorry it took so long. |
I’m thinking of replacing It’s only used once in Scapy, and will probably be much cleaner. Will look into that when I can |
@gpotter2 that could be a good idea! |
688ab87
to
e17b689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to be merged. @p-l- could you have a look? As it involves DNS, I think that it is safe to have another review =)
This PR:
dns_encode
DNS
anddns
tags, that were annoying)Bunch
andretry_test
on all test campaigns => remove the imports in the testsEdit:
The Unicode/UTF8 fix was removed from the PR, awaiting for a proper fix to be found