Skip to content

Conversation

polybassa
Copy link
Contributor

This PR tries to make CANSocket unit tests more reliable.

Since there is a sporadic error in this tests, I don't know how effective this changes are.

@polybassa polybassa changed the title try to make tests more reliable Try to make CANSocket unit tests more reliable Feb 22, 2019
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1863 into master will decrease coverage by 0.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
- Coverage   85.74%   85.02%   -0.73%     
==========================================
  Files         185      181       -4     
  Lines       42473    41127    -1346     
==========================================
- Hits        36420    34968    -1452     
- Misses       6053     6159     +106
Impacted Files Coverage Δ
scapy/arch/bpf/supersocket.py 27.6% <0%> (-49.33%) ⬇️
scapy/layers/usb.py 51.64% <0%> (-29.68%) ⬇️
scapy/arch/bpf/core.py 56.7% <0%> (-24.75%) ⬇️
scapy/layers/dhcp6.py 62.56% <0%> (-22.24%) ⬇️
scapy/consts.py 70.83% <0%> (-20.84%) ⬇️
scapy/arch/__init__.py 84.44% <0%> (-11.12%) ⬇️
scapy/arch/common.py 81.52% <0%> (-9.79%) ⬇️
scapy/contrib/isotp.py 82.01% <0%> (-6.31%) ⬇️
scapy/automaton.py 76.3% <0%> (-6.07%) ⬇️
scapy/route.py 86.13% <0%> (-5.11%) ⬇️
... and 21 more

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1863 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
+ Coverage   85.74%   85.76%   +0.01%     
==========================================
  Files         185      185              
  Lines       42473    42473              
==========================================
+ Hits        36420    36428       +8     
+ Misses       6053     6045       -8
Impacted Files Coverage Δ
scapy/layers/tls/handshake_sslv2.py 91.32% <0%> (-1.14%) ⬇️
scapy/automaton.py 81.81% <0%> (-0.56%) ⬇️
scapy/layers/inet6.py 88.28% <0%> (+0.05%) ⬆️
scapy/arch/windows/__init__.py 71.99% <0%> (+0.31%) ⬆️
scapy/sendrecv.py 86.05% <0%> (+1.02%) ⬆️
scapy/pton_ntop.py 97.26% <0%> (+8.21%) ⬆️

@polybassa polybassa force-pushed the can_ut_fix branch 2 times, most recently from 81c6aba to deef354 Compare February 22, 2019 08:53
@gpotter2
Copy link
Member

gpotter2 commented Feb 22, 2019

Thanks for the update ! Looking good (TBH I didnt check in details, but join() + delay fixes are a good basis 😄)

@gpotter2 gpotter2 merged commit 66d2cd7 into secdev:master Feb 22, 2019
@polybassa
Copy link
Contributor Author

polybassa commented Feb 22, 2019 via email

@gpotter2
Copy link
Member

gpotter2 commented Mar 25, 2019

Hi @polybassa, here’s another one
https://api.travis-ci.org/v3/job/510864342/log.txt
From
#1930

PyPy tend to mess up timings when performing the tests :/ might be related

@polybassa
Copy link
Contributor Author

thanks. I'll dig into that as soon as I find some free time

@polybassa polybassa deleted the can_ut_fix branch June 22, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants