-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Try to make CANSocket unit tests more reliable #1863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
- Coverage 85.74% 85.02% -0.73%
==========================================
Files 185 181 -4
Lines 42473 41127 -1346
==========================================
- Hits 36420 34968 -1452
- Misses 6053 6159 +106
|
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
+ Coverage 85.74% 85.76% +0.01%
==========================================
Files 185 185
Lines 42473 42473
==========================================
+ Hits 36420 36428 +8
+ Misses 6053 6045 -8
|
81c6aba
to
deef354
Compare
deef354
to
afa379d
Compare
Thanks for the update ! Looking good (TBH I didnt check in details, but |
Thanks. If you discover further sporadic errors, please let me know.
… On 22. Feb 2019, at 16:15, Gabriel ***@***.***> wrote:
Thanks for the update ! Looking good (TBH I didnt check it precisely 😄)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hi @polybassa, here’s another one PyPy tend to mess up timings when performing the tests :/ might be related |
thanks. I'll dig into that as soon as I find some free time |
This PR tries to make CANSocket unit tests more reliable.
Since there is a sporadic error in this tests, I don't know how effective this changes are.