Skip to content

Conversation

LRGH
Copy link
Contributor

@LRGH LRGH commented Dec 2, 2018

Fixes a bug introduced by commit cabeb47
I have reverted the modification introduced by this commit (but kept the new variable names, which did not break anything)
I have added a non-regression test with a DNS payload captured on my network.
I have removed a non-regression test that does not correspond to a real DNS payload.

@codecov-io
Copy link

Codecov Report

Merging #1722 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
+ Coverage   85.54%   85.58%   +0.03%     
==========================================
  Files         181      181              
  Lines       42131    42131              
==========================================
+ Hits        36042    36057      +15     
+ Misses       6089     6074      -15
Impacted Files Coverage Δ
scapy/layers/dns.py 91.51% <100%> (ø) ⬆️
scapy/layers/inet6.py 88.26% <0%> (+0.17%) ⬆️
scapy/asn1/ber.py 82.38% <0%> (+0.28%) ⬆️
scapy/sendrecv.py 83.13% <0%> (+0.34%) ⬆️
scapy/automaton.py 82.39% <0%> (+0.55%) ⬆️
scapy/layers/tls/record.py 92.1% <0%> (+0.87%) ⬆️
scapy/layers/tls/crypto/pkcs1.py 80.14% <0%> (+1.47%) ⬆️

1 similar comment
@codecov-io
Copy link

codecov-io commented Dec 2, 2018

Codecov Report

Merging #1722 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
+ Coverage   85.54%   85.58%   +0.03%     
==========================================
  Files         181      181              
  Lines       42131    42131              
==========================================
+ Hits        36042    36057      +15     
+ Misses       6089     6074      -15
Impacted Files Coverage Δ
scapy/layers/dns.py 91.51% <100%> (ø) ⬆️
scapy/layers/inet6.py 88.26% <0%> (+0.17%) ⬆️
scapy/asn1/ber.py 82.38% <0%> (+0.28%) ⬆️
scapy/sendrecv.py 83.13% <0%> (+0.34%) ⬆️
scapy/automaton.py 82.39% <0%> (+0.55%) ⬆️
scapy/layers/tls/record.py 92.1% <0%> (+0.87%) ⬆️
scapy/layers/tls/crypto/pkcs1.py 80.14% <0%> (+1.47%) ⬆️

@gpotter2 gpotter2 added the bug label Dec 2, 2018
@p-l- p-l- merged commit 7323bba into secdev:master Dec 5, 2018
@p-l-
Copy link
Member

p-l- commented Dec 5, 2018

Nice catch, and great PR. Thanks for that @LRGH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants