packet.time_sent can't be set because of object copy during list comprehension

[polybassa]

scapy/scapy/sendrecv.py

Line 186 in 254ab6d

tobesent = [p for p in pkt]

Is this list comprehension necessary at this position? Without a list comprehension, the time_sent values in the objects to be sent will be propagated to the original object. Because of the deep copy in the list comprehension, the time_sent is only set in a temporary object and not in the original object. This applies for all sr and sr1 function calls.

[guedou]

What issue are you facing that will require changing this line? Please provide an example.

[polybassa]

Hi, here is an example:

>>> TIMEOUT = 2
...:conf.verb = 0
...:packet = IP(dst="192.168.178.1", ttl=20)/ICMP()
...:reply = sr1(packet, timeout=TIMEOUT)
...:packet.sent_time is None
...:
True

[polybassa]

Here is another example. SuperSocket.send() sets the sent_time correctly

>>> TIMEOUT = 2
...:conf.verb = 0
...:packet = IP(dst="192.168.178.1", ttl=20)/ICMP()
...:reply = sr1(packet, timeout=TIMEOUT)
...:print(packet.sent_time)
...:s = L2Socket()
...:s.send(packet)
...:print(packet.sent_time)
...:
...:
None
1521442246.051092

[guedou]

Issue confirmed. I don't have time to investigate it.

[polybassa]

The problem ist not the mentioned line.
The issue is probably in packet.__iter__