Switch the order in which @before methods and setUp() are executed

[beberlei]

The methods that are tagged with @before are called after the setUp() method.

That makes it impossible to use traits for some generic setup code and then use the already existing services from the generic setup to do a specialed setUp, example:

class MyTest extends PHPunit_Framework_TestCase
{
    use ContainerSetup;

    public function setUp()
    {
           $this->container->get('..'); // if ContainerSetup has a `@before` hook, its not called here yet.
    }
}

[TomasVotruba]

I would love this feature too.

👍

[sebastianbergmann]

Can you send a pull request, @beberlei? I think this can go into 4.5.

[Dr-Head]

👍 agreed

[giorgiosironi]

I want to open a PR for this. Some questions to avoid implementing the wrong thing:

1. what should be the behavior for @after? By simmetry it should be called after tearDown()?
2. what should be the behavior of @beforeClass and @afterClass? Will they follow the same pattern of being called respectively before and after setUpBeforeClass() and tearDownAfterClass()?

[chungth]

+1

[Thijmen]

+1

[deeky666]

+1

[KingMob]

+1 @giorgiosironi what's the status of PR 1722? I see it failed a CI check.

[giorgiosironi]

It failed the run on PHP 7 which was unstable at the time, no test failure on current versions of PHP.
My questions at #1616 (comment) stills stand to define some other behavior so that I can finish it.

[sebastianbergmann]

I don't know what the right behavior would be, @giorgiosironi. Mostly due to the fact that I don't use @before, etc.

+1

[sebastianbergmann]

This should do what you propose, @beberlei, right?

diff --git a/src/Util/Test.php b/src/Util/Test.php
index 1dcc921..28594de 100644
--- a/src/Util/Test.php
+++ b/src/Util/Test.php
@@ -806,19 +806,31 @@ public static function getHookMethods($className)

                 foreach ($class->getMethods() as $method) {
                     if (self::isBeforeClassMethod($method)) {
-                        self::$hookMethods[$className]['beforeClass'][] = $method->getName();
+                        array_unshift(
+                            self::$hookMethods[$className]['beforeClass'],
+                            $method->getName()
+                        );
                     }

                     if (self::isBeforeMethod($method)) {
-                        self::$hookMethods[$className]['before'][] = $method->getName();
+                        array_unshift(
+                            self::$hookMethods[$className]['before'],
+                            $method->getName()
+                        );
                     }

                     if (self::isAfterMethod($method)) {
-                        self::$hookMethods[$className]['after'][] = $method->getName();
+                        array_unshift(
+                            self::$hookMethods[$className]['after'],
+                            $method->getName()
+                        );
                     }

                     if (self::isAfterClassMethod($method)) {
-                        self::$hookMethods[$className]['afterClass'][] = $method->getName();
+                        array_unshift(
+                            self::$hookMethods[$className]['afterClass'],
+                            $method->getName()
+                        );
                     }
                 }
             } catch (ReflectionException $e) {