Represent line-coverage data in objects #1109
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
============================================
- Coverage 88.56% 88.41% -0.15%
- Complexity 1382 1387 +5
============================================
Files 98 102 +4
Lines 4651 4712 +61
============================================
+ Hits 4119 4166 +47
- Misses 532 546 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
very interessting.. this PR does not yet yield a measurable performance improvement in the cases I tested. neither perf nor memory wise. still its a improvement regarding maintainability and readability. |
|
Why is this still a draft? Thanks. |
|
because it did not yield the expected perf results. if you are fine with the change we can still go ahead |
|
I think this is good to go. |
src/Data/ProcessedClassType.php
Outdated
| final class ProcessedClassType | ||
| { | ||
| public function __construct( | ||
| public readonly string $className, |
There was a problem hiding this comment.
Please do not introduce property promotion, thank you.
There was a problem hiding this comment.
here we go.
remaining CI error is related to a deprecated php-cs-fixer setting, not the PR itself
There was a problem hiding this comment.
Thank you! I have updated the configuration for PHP-CS-Fixer.
staabm
force-pushed
the
lineobj
branch
4 times, most recently
from
65603c9 to
c400997
Compare
|
Btw: motivation for this PR is also more strict structures, so we can level up phpstan and prevent bugs in the future |
|
would be great to get this merged, as it likely conflicts with other de-DOM-mification work along the way |
sebastianbergmann
merged commit 45dff46
into
sebastianbergmann:main
2 participants
analog #1105 but for regular line coverage data