Improve performance by skipping empty lines after filter has been applied #1085
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
|
This is a draft pull request that cannot be merged, but looks good to me. Do you think this should wait or can I merge it? |
|
I think we are good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see analysis in #1062 (comment) and later comments
with this PR we only run "skipEmptyLines" on files we are interessted in for coverage.
before this PR we normalized all data provided by xdebug, no matter we will need it later or not (based on the Filter)
on my m4 pro this improves performance..
when running
on Yoast/PHPUnit-Polyfills@55860f0
on windows likely even more as we reduce a lot of IO which is especially slow on windows
as this fix improves phpunit 11.x and 12.x in a similar way, there seems to be still other differences need further investigation perf wise