Add support for preloading files in nested directories #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `PhpWeb` constructor's `files` parameter and tag attribute `data-files` to preload files with nested directory structure.
|
Didn't test building this yet, just patched this code locally in NPM package sources and got with Composer |
|
@jasalt What would be needed to move this MR out of draft? |
|
@Potherca thank's for the nudge, forgot to send it for review. |
|
Ping @seanmorris, noted some demand with this addition, would you review when ever you have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
PhpWebconstructor'sfilesparameter and tag attributedata-filesto preload files with nested directory structure.This way e.g. Composer's
vendordirectory can be preloaded by specifying it's content as a single JSON object / file which can be created with script such as https://gist.github.com/jasalt/b50f60914be75b8dd3ee18f878d801c1.Provides alternate way to initializing WASM FS where currently copying a single compressed file and extracting it in WASM PHP code is one popular method. This does not require running any PHP initialization code in Wasm.