Add support for client ID #327
Open
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wprzytula
requested changes
Nov 21, 2025
wprzytula
requested changes
Nov 21, 2025
Instead of extending client options after converting them to rust options, we extend them with default values before that. There were some inconsistencies in handling some default values that are fix in this PR.
Compared to the DSx driver, this supports ids both as uuid and strings. When uuid is provided, it's converted to string, as this is how client id is represented in the Rust driver.
adespawn
force-pushed
the
add-support-for-client-id
branch
from
d5550ce to
51c92ed
Compare
wprzytula
requested changes
Nov 21, 2025
Comment on lines
+667
to
+669
| if (rustOptions.cacheSize) { | ||
| rustOptions.cacheSize = options.maxPrepared; | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't this condition be if (options.maxPrepared)?
Contributor
There was a problem hiding this comment.
If yes, then we again lack testing - in this case unit testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the DSx driver, this supports ids both as uuid and strings. When uuid is provided, it's converted to string, as this is how client id is represented in the Rust driver.
Fixes #322