New error handling #313
Draft
New error handling #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for custom errors. The new logic allows for setting additional values inside the JS error object, compared to Errors exposed by the napi-rs, that allows only setting error message and kind. This is intended to be a easy replacement of the current errors with only minor refactor required.
This can be done through some macro, instead of doing it manually, but I wanted to validate the idea, before doing so.
adespawn
force-pushed
the
new-error-handling
branch
from
abeab80 to
e51efa5
Compare
Contributor
Author
|
@wprzytula If you could look at it, to make sure the general idea makes sens, before I update all the error handling to this new format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for this PR, is to include the name of the Rust error type, in the thrown error.
In the future, current approach can be extended to contain more information,
that cannot be passed with the current error handling implementation.
The other benefit of this PR is that all error construction will happen on the Rust side,
so we no longer need to remember which function may return errors, and handle them (see #216)
I turns out https://doc.rust-lang.org/std/ops/trait.FromResidual.html is still experimental.
If this were to be merged, after updating all places where we return napi::Error, this would fix:
Fixes #119
Fixes #216 (We update the whole process, so this is no longer necessary)