4.x: Change driver.name to ScyllaDB Java Driver #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
changed the title
dkropachev
approved these changes
Aug 5, 2024
|
@Bouncheck Here CI is failing too. Why? |
Author
|
Looks like usual flakiness. Ccm failed to start at some point and testing environment got messed up. |
Changes the driver.name in Driver.properties file. Fixes scylladb#300
Bouncheck
force-pushed
the
scylla-4.x-name-change
branch
from
5e4bf5c to
a231096
Compare
|
Do you have plans to work on this? I see that both 3.x and 4.x are flaky (but for different reasons). |
Lorak-mmk
approved these changes
Aug 5, 2024
Author
|
Currently I don't but it may be worth attaching to an issue for later planning. |
roydahan
approved these changes
Aug 5, 2024
|
Please open such an issue. CI stability is important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the driver.name in Driver.properties file.
Fixes #300.