Skip to content

Refactor of labels logic #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timtreis
Copy link
Member

No description provided.

@timtreis timtreis linked an issue Aug 28, 2024 that may be closed by this pull request
@timtreis timtreis changed the title contour_px is now evaluated, even if outline_alpha == fill_alpha Refactor of labels logic Aug 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (bd285f6) to head (86ecc44).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/render.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   79.26%   84.49%   +5.22%     
==========================================
  Files          11        8       -3     
  Lines        1799     1554     -245     
==========================================
- Hits         1426     1313     -113     
+ Misses        373      241     -132     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 94.40% <90.90%> (-0.40%) ⬇️

... and 5 files with indirect coverage changes

@timtreis timtreis self-assigned this Aug 28, 2024
@timtreis timtreis merged commit 7147a64 into main Aug 29, 2024
5 checks passed
@timtreis timtreis deleted the bugfix/335-contour_px-not-respected-when-outline_alpha-=-fill_alpha branch August 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants