Skip to content

Conversation

@ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold modified the milestones: 1.11.6, 1.12.0 Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.77%. Comparing base (dd6e6fd) to head (ffad853).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3872   +/-   ##
=======================================
  Coverage   76.76%   76.77%           
=======================================
  Files         115      115           
  Lines       12365    12370    +5     
=======================================
+ Hits         9492     9497    +5     
  Misses       2873     2873           
Flag Coverage Δ
hatch-test.pre 76.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/get/_aggregated.py 92.78% <100.00%> (+0.17%) ⬆️

@ilan-gold ilan-gold marked this pull request as ready for review November 10, 2025 09:45
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, just some stylistic stuff. Great work!

I’m not super happy about the added complexity, but I also don’t know if we could do it better:

e.g. it doesn’t look like we can pull out everything depending on {un,}chunked_axis and pass that in from a function that just exists to handle that complexity, things are too interwoven. What do you think?

@flying-sheep
Copy link
Member

what do you say to what I wrote in #3872 (review)?

@ilan-gold
Copy link
Contributor Author

what do you say to what I wrote in #3872 (review)?

Ah yeah, I meant to reply to that. I can look into it. Let's leave this PR as-is. I'll open a new one into this one fiddling around with it. If it looks to be too complex, I may just punt and say "FAU when we can"

Base automatically changed from ig/csc_dask_tests to main November 10, 2025 13:48
@ilan-gold ilan-gold enabled auto-merge (squash) November 10, 2025 14:00
@ilan-gold ilan-gold merged commit 6605dd3 into main Nov 10, 2025
14 checks passed
@ilan-gold ilan-gold deleted the ig/aggregate_csc branch November 10, 2025 14:08
@flying-sheep flying-sheep mentioned this pull request Nov 17, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sc.get.aggregate with CSC dask

3 participants