Skip to content

Conversation

@flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Mar 3, 2025

Fixes #45

@flying-sheep flying-sheep changed the title skeleton Add mean_var Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.44%. Comparing base (a38413d) to head (8317937).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/fast_array_utils/stats/_mean_var.py 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   95.05%   94.44%   -0.62%     
==========================================
  Files          12       14       +2     
  Lines         182      234      +52     
==========================================
+ Hits          173      221      +48     
- Misses          9       13       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #46 will degrade performances by 52.33%

Comparing pa/mean-var (8317937) with main (2c7a94a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 68 untouched benchmarks
🆕 18 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_stats_benchmark[0-numpy.ndarray-float32-mean_var] N/A 345.7 µs N/A
🆕 test_stats_benchmark[0-numpy.ndarray-float64-mean_var] N/A 326.2 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csc_array-float32-mean_var] N/A 164.1 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csc_array-float64-mean_var] N/A 180.5 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csr_array-float32-mean_var] N/A 335.5 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csr_array-float64-mean_var] N/A 348.8 µs N/A
🆕 test_stats_benchmark[1-numpy.ndarray-float32-mean_var] N/A 339.1 µs N/A
🆕 test_stats_benchmark[1-numpy.ndarray-float64-mean_var] N/A 320.9 µs N/A
🆕 test_stats_benchmark[1-scipy.sparse.csc_array-float32-mean_var] N/A 338.8 µs N/A
🆕 test_stats_benchmark[1-scipy.sparse.csc_array-float64-mean_var] N/A 353 µs N/A
test_stats_benchmark[1-scipy.sparse.csr_array-float32-is_constant] 97.6 µs 204.7 µs -52.33%
🆕 test_stats_benchmark[1-scipy.sparse.csr_array-float32-mean_var] N/A 160.7 µs N/A
test_stats_benchmark[1-scipy.sparse.csr_array-float64-is_constant] 216.3 µs 96.1 µs ×2.3
🆕 test_stats_benchmark[1-scipy.sparse.csr_array-float64-mean_var] N/A 176.6 µs N/A
🆕 test_stats_benchmark[None-numpy.ndarray-float32-mean_var] N/A 346.3 µs N/A
🆕 test_stats_benchmark[None-numpy.ndarray-float64-mean_var] N/A 331 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csc_array-float32-mean_var] N/A 698.6 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csc_array-float64-mean_var] N/A 740.2 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csr_array-float32-mean_var] N/A 679.5 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csr_array-float64-mean_var] N/A 714.7 µs N/A

@flying-sheep flying-sheep marked this pull request as ready for review March 4, 2025 10:55
@flying-sheep flying-sheep requested a review from ilan-gold March 4, 2025 10:59
@flying-sheep flying-sheep requested a review from ilan-gold March 4, 2025 13:58
@flying-sheep flying-sheep merged commit 9761bee into main Mar 4, 2025
8 of 9 checks passed
@flying-sheep flying-sheep deleted the pa/mean-var branch March 4, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New function: mean_var

3 participants