Skip to content

Conversation

@flying-sheep
Copy link
Member

No description provided.

@flying-sheep flying-sheep changed the base branch from main to pa/sum February 18, 2025 12:26
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (9ae63ae) to head (5e497b3).
Report is 1 commits behind head on pa/sum.

Additional details and impacted files
@@           Coverage Diff           @@
##           pa/sum      #17   +/-   ##
=======================================
  Coverage   78.03%   78.03%           
=======================================
  Files           9        9           
  Lines         173      173           
=======================================
  Hits          135      135           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #17 will improve performances by 24.73%

Comparing pa/numpy-sum (5e497b3) with pa/sum (9ae63ae)

Summary

⚡ 21 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_sum_benchmark[numpy.ndarray-0-float32] 106.7 µs 85.6 µs +24.73%
test_sum_benchmark[numpy.ndarray-0-float64] 127.9 µs 106.8 µs +19.79%
test_sum_benchmark[numpy.ndarray-1-float32] 111.4 µs 90.3 µs +23.44%
test_sum_benchmark[numpy.ndarray-1-float64] 130.7 µs 108.9 µs +20.03%
test_sum_benchmark[numpy.ndarray-None-float32] 107 µs 86.1 µs +24.29%
test_sum_benchmark[numpy.ndarray-None-float64] 125.4 µs 104.4 µs +20.08%
test_sum_benchmark[scipy.sparse.csc_array-1-float32] 273.5 µs 246.2 µs +11.1%
test_sum_benchmark[scipy.sparse.csc_array-None-float32] 268.7 µs 240.7 µs +11.65%
test_sum_benchmark[scipy.sparse.csc_array-None-float64] 290.5 µs 262.6 µs +10.6%
test_sum_benchmark[scipy.sparse.csc_matrix-0-float32] 374.9 µs 306.1 µs +22.46%
test_sum_benchmark[scipy.sparse.csc_matrix-0-float64] 404.1 µs 329.1 µs +22.78%
test_sum_benchmark[scipy.sparse.csc_matrix-1-float32] 337.8 µs 281.7 µs +19.89%
test_sum_benchmark[scipy.sparse.csc_matrix-1-float64] 366.1 µs 313.9 µs +16.64%
test_sum_benchmark[scipy.sparse.csc_matrix-None-float32] 336.2 µs 285.1 µs +17.96%
test_sum_benchmark[scipy.sparse.csc_matrix-None-float64] 353.1 µs 304.4 µs +15.99%
test_sum_benchmark[scipy.sparse.csr_array-None-float32] 254.1 µs 228.3 µs +11.33%
test_sum_benchmark[scipy.sparse.csr_array-None-float64] 279.6 µs 253.8 µs +10.15%
test_sum_benchmark[scipy.sparse.csr_matrix-1-float32] 382.5 µs 312.2 µs +22.51%
test_sum_benchmark[scipy.sparse.csr_matrix-1-float64] 408.6 µs 339 µs +20.53%
test_sum_benchmark[scipy.sparse.csr_matrix-None-float32] 319.4 µs 267 µs +19.62%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@flying-sheep flying-sheep marked this pull request as ready for review February 18, 2025 12:41
@flying-sheep flying-sheep merged commit f3f683c into pa/sum Feb 18, 2025
11 checks passed
@flying-sheep flying-sheep deleted the pa/numpy-sum branch February 18, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants