Skip to content

Conversation

@luca992
Copy link

@luca992 luca992 commented Sep 26, 2023

Copied to match upstream:
https://github.com/CosmWasm/cosmwasm/blob/09555ac1295f1f9129fd1fa5139d19763d16d2a1/packages/std/src/results/cosmos_msg.rs#L159C8-L159C8

Also, fixes setting mock_env hash.

However, I am testing it out in my example contract, and setting admin from rust does not appear to be working. Is there maybe some reason the admin param wouldn't be read automatically on the GO side? ... It very well could be a mistake on my side, I'm still testing it out. I'm using a local secret v1.11.0 instance

here's where I'm setting it for reference:
https://github.com/eqoty-labs/snip721-migratable/blob/aea67604348f29d779172abb803cf6e0cee5f52e/contracts/snip721-dealer/src/contract.rs#L77
@assafmo

@assafmo
Copy link

assafmo commented Sep 26, 2023

Thanks! I'm afraid that's a bug that we'll need to fix in a future upgrade. 😢

@luca992
Copy link
Author

luca992 commented Sep 26, 2023

Thanks! I'm afraid that's a bug that we'll need to fix in a future upgrade. 😢

Damn, I kinda need this at least on testnet :/. I looked in the SecretNetwork repo and found the rust types there were also missing the admin param, add them in a pr. Not sure if other additional work is needed as I can't build it on my mac. But that's probably the most I can help.

@assafmo assafmo changed the base branch from ibc-msg-transfer-memo to secret-v1.12 October 4, 2023 07:14
@assafmo assafmo merged commit ed247c8 into scrtlabs:secret-v1.12 Oct 4, 2023
@assafmo
Copy link

assafmo commented Oct 4, 2023

Thanks @luca992!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants