Testing Admin in init #1553
Merged
Testing Admin in init #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at you protogen) but I don't know what
eshelB
requested review from
Cashmaney,
assafmo,
liorbond and
toml01
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does not work locally, there's some glue missing betweenhandler(andkeeper.Instantiate(, the admin field get dropped somewhere in the middle, thing is I don't think I have the code for there, somewhere in sdk or something.... maybe protobuf's to blame.Either way, checking if CI can deal with this
Edit: now it works locally after fixing another thing