-
Notifications
You must be signed in to change notification settings - Fork 626
(libzkp): refactor batch header variants #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thegaram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Purpose or design rationale of this PR
Incorporate refactoring changes proposed in scroll-tech/zkvm-prover#225.
This in addition to #1754 will avoid implementation confusion between
da-codecandzkvm-prover. Since da-codec v7, v8 and v9 are effectively identical (except the version byte), we cover all the 3 cases in a single umbrella variantV7_V8_V9and instead make use of theVersionto convey stf-version and codec-version.Before merging, we must wait for:
zkvm-provertag (rc.4) instead of depending onchore/galileo-refactor-headerBreaking change label
Does this PR have the
breaking-changelabel?