Skip to content

Conversation

@roynalnaruto
Copy link
Contributor

@roynalnaruto roynalnaruto commented Nov 18, 2025

Purpose or design rationale of this PR

Incorporate refactoring changes proposed in scroll-tech/zkvm-prover#225.

This in addition to #1754 will avoid implementation confusion between da-codec and zkvm-prover. Since da-codec v7, v8 and v9 are effectively identical (except the version byte), we cover all the 3 cases in a single umbrella variant V7_V8_V9 and instead make use of the Version to convey stf-version and codec-version.

Before merging, we must wait for:

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/galileo-refactor-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noel2004 noel2004 merged commit 4a8eb78 into feat/galileo Nov 18, 2025
2 checks passed
@noel2004 noel2004 deleted the chore/galileo-refactor-header branch November 18, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants