Skip to content

Conversation

@colinlyguo
Copy link
Contributor

@colinlyguo colinlyguo commented May 27, 2025

Purpose or design rationale of this PR

This PR fixes a bug in bridge-history, the new logic treats all unsuccessful withdrawals as unclaimed.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced retrieval of L2 unclaimed withdrawal messages to include additional transaction statuses.
  • Chores

    • Updated version to v4.5.20.

@coderabbitai
Copy link

coderabbitai bot commented May 27, 2025

Walkthrough

The changes update the logic for retrieving L2 unclaimed withdrawals by broadening the transaction status filter to include sent, failed relayed, and reverted relay statuses. Additionally, the project version number is incremented from v4.5.19 to v4.5.20.

Changes

File(s) Change Summary
bridge-history-api/internal/orm/cross_message.go Modified query to include messages with tx_status in {TxStatusTypeSent, TxStatusTypeFailedRelayed, TxStatusTypeRelayTxReverted} instead of only TxStatusTypeSent.
common/version/version.go Updated version string from "v4.5.19" to "v4.5.20".

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ORM
    participant Database

    Caller->>ORM: GetL2UnclaimedWithdrawalsByAddress(address)
    ORM->>Database: Query messages where tx_status in {Sent, FailedRelayed, RelayTxReverted} and sender = address
    Database-->>ORM: Return unclaimed withdrawal messages
    ORM-->>Caller: Return filtered messages
Loading

Suggested labels

bump-version

Suggested reviewers

  • Thegaram
  • jonastheis

Poem

A hop and a skip, the version hops on,
From nineteen to twenty, the count marches on.
Withdrawals now filtered with care and with pride,
Sent, failed, or reverted—all now side by side.
With every small change, the bridge grows more strong,
🐇 Onward we code, with a hop and a song!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86a6e50 and 7bf1092.

📒 Files selected for processing (1)
  • bridge-history-api/internal/orm/cross_message.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bridge-history-api/internal/orm/cross_message.go
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: tests
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@colinlyguo colinlyguo requested review from Thegaram and georgehao May 27, 2025 14:22
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.87%. Comparing base (f824fb0) to head (7bf1092).

Files with missing lines Patch % Lines
bridge-history-api/internal/orm/cross_message.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1671   +/-   ##
========================================
  Coverage    40.87%   40.87%           
========================================
  Files          225      225           
  Lines        18071    18071           
========================================
  Hits          7386     7386           
  Misses        9968     9968           
  Partials       717      717           
Flag Coverage Δ
bridge-history-api 8.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

georgehao
georgehao previously approved these changes May 27, 2025
@colinlyguo colinlyguo merged commit 5204ad5 into develop May 27, 2025
6 checks passed
@colinlyguo colinlyguo deleted the fix-bridge-history-unclaimed-withdrawals branch May 27, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants