fix(relayer): ProcessPendingBatches #1661
Conversation
WalkthroughThe version tag in the versioning file was incremented from "v4.5.14" to "v4.5.15". Additionally, the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Layer2Relayer
participant Database
Caller->>Layer2Relayer: ProcessPendingBatches()
Layer2Relayer->>Database: Fetch pending batches
Database-->>Layer2Relayer: Return dbBatches
alt dbBatches is empty
Layer2Relayer-->>Caller: Return immediately
else dbBatches not empty
Layer2Relayer->>Layer2Relayer: Continue processing batches
end
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd"" Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
common/version/version.go(1 hunks)rollup/internal/controller/relayer/l2_relayer.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: rollup-db-cli
- GitHub Check: rollup_relayer
- GitHub Check: gas_oracle
- GitHub Check: coordinator-cron
- GitHub Check: bridgehistoryapi-fetcher
- GitHub Check: bridgehistoryapi-db-cli
- GitHub Check: bridgehistoryapi-api
- GitHub Check: coordinator-api
🔇 Additional comments (1)
common/version/version.go (1)
8-8: Version bump looks good.The version was updated from v4.5.12 to v4.5.13, which is appropriate for a bugfix release.
Thegaram
dismissed stale reviews from colinlyguo, ranchalp, and themself
via
5c4509d
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1661 +/- ##
===========================================
- Coverage 41.03% 41.00% -0.03%
===========================================
Files 225 225
Lines 18028 18031 +3
===========================================
- Hits 7397 7393 -4
- Misses 9908 9913 +5
- Partials 723 725 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
fix nil pointer if there's no pending batches
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
Bug Fixes
Chores