-
Notifications
You must be signed in to change notification settings - Fork 32
Feat deployment alt gas token #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a9e8d35
4be3001
0e62f08
a87c7d7
591b875
466c88a
7620c50
1ffb7da
b1f9ecf
a06bb49
a411597
ab8002e
3082fc1
fbd92da
85cd399
b4d7694
b4cc238
61ebdd1
4d2b3c6
5489c1d
ca2acbe
429c441
ee696f8
b8d6ec9
161b2dd
2f3e91e
923ead9
18a483e
446bd8f
91aee29
e5bdf6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,13 +14,15 @@ | |
"dai_gateway": "0x0000000000000000000000000000000000000000", | ||
"usdc_gateway": "0x0000000000000000000000000000000000000000", | ||
"lido_gateway": "0x0000000000000000000000000000000000000000", | ||
"puffer_gateway": "0x0000000000000000000000000000000000000000" | ||
"puffer_gateway": "0x0000000000000000000000000000000000000000", | ||
"gas_token_gateway": null | ||
}, | ||
"scroll_messenger": null, | ||
"message_queue": null, | ||
"scroll_chain": null | ||
"scroll_chain": null, | ||
"gas_token": null | ||
}, | ||
"start_messenger_balance": null | ||
"start_messenger_balance": 0 | ||
Comment on lines
-23
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why 0? L1 messenger balance will not be 0 in a real deployment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realized it's missing. Added a draft here: #24 probably needs some adjustments. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think contracts don't need chain_monitor config, also the bridge-history-config.json There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, this is mainly because we want to have a single command to generate all config files for scroll-sdk, so here the file https://github.com/scroll-tech/scroll-contracts/blob/feat-deployment-alt-gas-token/docker/scripts/gen-configs.sh will help to do so. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i see. but i don't like this way. why not generate the configs in scroll-sdk repo? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure, I guess that because lots of config files need contracts addresses. generate the config files here would be convenient to get/predict those addresses? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is a convenient way to generate the configs before actually deploying the contracts. But I'm fine with moving the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For this, my original thinking is to burn rest of the deployer balance to all zero address, so we can set chain monitor but with #24 , would be better. |
||
}, | ||
"l2_config": { | ||
"l2_url": null, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,7 @@ | |
"gas_price_diff": 50000 | ||
}, | ||
"chain_monitor": { | ||
"enabled": false, | ||
"enabled": true, | ||
"timeout": 3, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why contract need There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is mainly because we want to have a single command to generate all config files for scroll-sdk, so here the file https://github.com/scroll-tech/scroll-contracts/blob/feat-deployment-alt-gas-token/docker/scripts/gen-configs.sh will help to do so. |
||
"try_times": 5, | ||
"base_url": "http://chain-monitor:8080" | ||
|
Uh oh!
There was an error while loading. Please reload this page.