tests: add test fixture for easier abstraction #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #407 will not alter performanceComparing Summary
|
frisitano
reviewed
Nov 4, 2025
Comment on lines
+95
to
+102
| pub fn sequencer() -> TestFixtureBuilder { | ||
| TestFixtureBuilder::new().with_sequencer() | ||
| } | ||
|
|
||
| /// Create a new test fixture builder for follower nodes. | ||
| pub fn followers(count: usize) -> TestFixtureBuilder { | ||
| TestFixtureBuilder::new().with_nodes(count) | ||
| } |
There was a problem hiding this comment.
Should these methods instead consume self so we can chain them? Something like TestFixture::builder().sequencer().followers(2)
frisitano
reviewed
Nov 4, 2025
| /// The underlying node context. | ||
| pub node: NodeHelperType<ScrollRollupNode, TestBlockChainProvider>, | ||
| /// Engine instance for this node. | ||
| pub engine: Engine<ScrollAuthApiEngineClient<EC>>, |
There was a problem hiding this comment.
Can you erase the type here using:
pub engine: Engine<dyn ScrollEngineApi>,
jonastheis
reviewed
Nov 4, 2025
| let events = &mut self.fixture.nodes[self.node_index].chain_orchestrator_rx; | ||
|
|
||
| let result = timeout(self.timeout_duration, async { | ||
| while let Some(event) = events.next().await { |
There was a problem hiding this comment.
For debugging purposes we should log all events here (matching and non matching). This makes it much easier to understand which events are being processed/fired instead of the expected one. Similar to what is done in wait_for_event_predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the update of the test setup. Provides a set of high level abstractions that allow testers to easily set up initial tests conditions, run the test and directly expect test outcome.