Skip to content

chore: merge upstream 9d1af5a09 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 301 commits into
base: scroll
Choose a base branch
from
Open

chore: merge upstream 9d1af5a09 #295

wants to merge 301 commits into from

Conversation

greged93
Copy link
Collaborator

Merges upstream changes into Reth. Main changes:

  • System call update using the new revm interface.
  • CLI update
  • AddOns interface simplified

leopardracer and others added 30 commits July 4, 2025 14:53
@leopardracer
docs: fix typo in documentation comments (paradigmxyz#17207)
47d2ed5
@Dyslex7c @mattsse
feat(p2p): separate args for (header, body) (paradigmxyz#17184)
89d0e6a 
Co-authored-by: Matthias Seitz <[email protected]>
@fantasyup @mattsse
chore(doc): update exclude list for doc/cli (paradigmxyz#17234)
dcf3469 
Co-authored-by: Matthias Seitz <[email protected]>
@fantasyup
chore: add capabilities to NetworkStatus (paradigmxyz#17236)
ca36316
@Galoretka
fix: logical error in pruning test for storage_history PruneMode::Full (
e948ab1 
paradigmxyz#17235)
@reallesee
docs: fix typo mod.rs (paradigmxyz#17233)
29c1a35
@frankudoags
refactor(txpool): Remove txhash from PoolUpdate (paradigmxyz#17239)
593477c 
Co-authored-by: frankudoags <frankudoags.com>
@varun-doshi @mattsse
feat: add v5 flashbots relay block validation api for Fusaka (paradig…
beb8fac 
…mxyz#17179)

Co-authored-by: Matthias Seitz <[email protected]>
@aso20455
fix: correct typo in ValidationApi comment (paradigmxyz#17241)
30a9690
@leopardracer
docs: Consistent Spelling for "Reuse" in Documentation (paradigmxyz#1…
0592bd0 
…7232)
@frankudoags
refactor(rpc): Arc PendingBlock internals (paradigmxyz#17240)
1e9866c 
Co-authored-by: frankudoags <frankudoags.com>
@eeemmmmmm
docs: correction comments (paradigmxyz#17244)
3277333
@Fallengirl
docs: deleted extra duplicate environment.rs (paradigmxyz#17249)
8e800d6
@github-actions @github-merge-queue
chore(deps): weekly cargo update (paradigmxyz#17247)
651f1b9 
Co-authored-by: github-merge-queue <[email protected]>
@schoentgenaa
fix: correct comment in static file writer (paradigmxyz#17254)
44b361a
@shekhirin
fix(trie): ParallelSparseTrie::default should have an empty root no…
a64dafd 
…de (paradigmxyz#17256)
@fgimenez
refactor: extract import functionality to separate module (paradigmxy…
e70f687 
…z#17253)
@dizer-ti
docs: fix typo fileted to filtered (paradigmxyz#17257)
1f557b3
@crStiv
docs: typos (paradigmxyz#17246)
927e9c4
@mediocregopher
fix(trie): track branch node updates only in ParallelSparseTrie, not …
468e925 
…subtries (paradigmxyz#17223)
@fgimenez
feat(test): allow to create testing nodes with specific datadir (para…
dddde9e 
…digmxyz#17260)
@fgimenez
feat(test): spin up e2e test nodes with imported data (paradigmxyz#17261
e66caca 
)
@shekhirin
fix(trie): add lower subtrie root paths to upper subtrie prefix set (p…
09b4c5e 
…aradigmxyz#17262)
@mattsse
chore: update size metrics once (paradigmxyz#17242)
e457432
@klkvr
chore: check blob fee (paradigmxyz#17272)
78bad34
@bford21
fix: dead link (paradigmxyz#17200)
1eccb5b
@Galoretka
chore: Fix typo in block number reader comment (paradigmxyz#17250)
36d568a
@VolodymyrBg
chore: fix typos (paradigmxyz#17251)
af004c0
@GarmashAlex
docs: fix typo basfee → basefee in txpool.mmd (paradigmxyz#17252)
7c69ab1
@mattsse
chore: bump alloy (paradigmxyz#17275)
5645659
klkvr and others added 24 commits July 23, 2025 22:39
@klkvr
refactor: small simplifications for tree types (paradigmxyz#17589)
6b23818
@danielrachi1 @mattsse
feat: Add IPC socket permission configuration (paradigmxyz#17497)
e29707f 
Co-authored-by: Matthias Seitz <[email protected]>
@sashaodessa
fix: typo in Cargo.toml (paradigmxyz#17588)
dc90eb2
@mattsse
chore: introduce engine module (paradigmxyz#17591)
876e964
@lean-apple
test(era1): add more Receipt tests to verify decoding (paradigmxyz#…
de5cbfe 
…17592)
@emhane
test(sdk): Add test for using node builder with noop components (para…
a7cbf81 
…digmxyz#17560)
@mablr
feat(rpc): add method to configure custom tokio runtime for RPC server (
c549188 
paradigmxyz#17611)
@LandLord529
docs: correct error comments in networking optimism modules (paradigm…
0a416d3 
…xyz#17602)
@fgimenez
chore: make clippy happy (paradigmxyz#17620)
7309130
@lean-apple
chore: remove duplicate deps (paradigmxyz#17618)
3f3ccc3
@anim001k
fix: Benchmarking Link in database.md (paradigmxyz#17553)
5748cf9
@mattsse @klkvr
feat: support any network type in eth api builder (paradigmxyz#17617)
8796a77 
Co-authored-by: Arsenii Kulikov <[email protected]>
@crStiv
docs: fix typos (paradigmxyz#17624)
e63dafb
@MozirDmitriy
fix: correct comment for is_latest_invalid method (paradigmxyz#17621)
812dd04
@github-actions @github-merge-queue @mattsse
chore(deps): weekly cargo update (paradigmxyz#17628)
7ed3ab0 
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
@klkvr
chore: relax Cli::run_with_components (paradigmxyz#17630)
d392c3f
@klkvr @mattsse
refactor: introduce Enginvalidator in tree (paradigmxyz#17598)
9d1af5a 
Co-authored-by: Matthias Seitz <[email protected]>
@greged93
Merge branch 'main' into chore-merge-upstream-9d1af5a09
9979e1a 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
Merge branch 'scroll' into chore-merge-upstream-9d1af5a09
26b9302
@greged93
feat: update ScrollAddOns
b1ae217 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: update bin
485d7ab 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
test: update
2ae382d 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: evm and attributes update
6446b46 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: eth api update
daa0600 
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 requested a review from frisitano July 29, 2025 11:42
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #295 will not alter performance

Comparing chore-merge-upstream-9d1af5a09 (67e7759) with scroll (357655f)

Summary

✅ 77 untouched benchmarks

greged93 added 3 commits July 29, 2025 15:55
@greged93
chore: fix lints
01fd5af 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
fix: open vm
44cd240 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
chore: point revm to scroll branch
67e7759 
Signed-off-by: Gregory Edison <[email protected]>
frisitano
frisitano approved these changes Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/scroll/node/src/addons.rs
sequencer_url: None,
payload_size_limit: SCROLL_DEFAULT_PAYLOAD_SIZE_LIMIT,
// TODO (scroll): update with default values.
min_suggested_priority_fee: 1_000_000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to change this before merging or after? If the later then lets create an issue to track this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting for PR #291 to be merged, these changes were added just to make the later merge easier.

crates/scroll/rpc/src/eth/mod.rs
Comment on lines +318 to +320
// TODO (scroll): update default values.
min_suggested_priority_fee: 0,
payload_size_limit: 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we create an issue to track these values as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisitano frisitano frisitano approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.