Skip to content

Conversation

@yiweichi
Copy link
Member

@yiweichi yiweichi commented Sep 3, 2025

1. Purpose or design rationale of this PR

This PR aims to fix the zstd deadlock issue by updating the da-codec version.
da-codec pr: scroll-tech/da-codec#61

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Upgraded an internal third‑party codec dependency to a newer build.
    • Bumped the product patch version from 5.9.3 to 5.9.4.
    • No changes to features, UI, commands, configuration, or public APIs; functionality remains consistent.

@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025

Walkthrough

Bumped the github.com/scroll-tech/da-codec module version in go.mod and incremented the package patch version constant (VersionPatch) in params/version.go from 3 to 4, updating the computed product version from 5.9.3 to 5.9.4. No other logic changes.

Changes

Cohort / File(s) Summary
Dependency version bump
go.mod
Updated github.com/scroll-tech/da-codec version from v0.1.3-0.20250626091118-58b899494da6 to v0.1.3-0.20250825071838-cddc263e5ef6.
Version constant bump
params/version.go
Incremented VersionPatch from 3 to 4, changing computed Version from 5.9.3 to 5.9.4 and updating derived version values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Thegaram
  • colinlyguo

Suggested labels

bump-version

Poem

I twitch my whiskers, hop with cheer,
A tiny bump, the path is clear.
Versions nudged and tidy, neat—
Carrot bytes for every seat. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b61d7df and 6d9e09e.

📒 Files selected for processing (1)
  • params/version.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • params/version.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-and-push
  • GitHub Check: Analyze (go)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-update-da-codec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
go.mod (2)

54-54: Add a lightweight regression test to guard against the deadlock.

Even if fixed upstream, a small concurrent encode/decode test here would prevent regressions in our integration surface. Run multiple goroutines that exercise the da-codec path under load and assert completion within a timeout.

I can draft a minimal Go test skeleton that targets the hot path you use (once you point me to the package/function entrypoints).


54-54: Update klauspost/compress indirect dependency to v1.18.0
go.mod currently pins github.com/klauspost/compress v1.17.9 // indirect, but v1.18.0 (released Feb 19 2025) includes zstd deadlock fixes—bump the indirect require (or remove it to float) to adopt v1.18.0 and avoid reintroducing known issues.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2ee0371 and b61d7df.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Analyze (go)
🔇 Additional comments (3)
go.mod (3)

54-54: LGTM: da-codec bump aligns with the stated goal (zstd deadlock fix).

The version bump to github.com/scroll-tech/da-codec v0.1.3-0.20250825071838-cddc263e5ef6 matches the PR objective to pull in the deadlock fix. No other deps were changed.


54-54: Module hygiene verified: go.sum includes the new da-codec v0.1.3-0.20250825071838-cddc263e5ef6 checksums (lines 399–400) and no vendor directory is present.


54-54: Verify no breaking changes across da-codec importers
Import sites for github.com/scroll-tech/da-codec/encoding were found in rollup/fees, da_syncer, rollup_sync_service, l1/reader, missing_header_fields, and core/rawdb. After bumping to v0.1.3-0.20250825071838-cddc263e5ef6, run:

go mod tidy && go build ./... && go test ./...

to confirm no compilation errors or test failures.

@yiweichi yiweichi merged commit afbbad7 into develop Sep 4, 2025
5 checks passed
@yiweichi yiweichi deleted the fix-update-da-codec branch September 4, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants