-
Notifications
You must be signed in to change notification settings - Fork 284
fix: update da-codec to prevent zstd deadlock #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumped the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
go.mod (2)
54-54: Add a lightweight regression test to guard against the deadlock.Even if fixed upstream, a small concurrent encode/decode test here would prevent regressions in our integration surface. Run multiple goroutines that exercise the da-codec path under load and assert completion within a timeout.
I can draft a minimal Go test skeleton that targets the hot path you use (once you point me to the package/function entrypoints).
54-54: Update klauspost/compress indirect dependency to v1.18.0
go.mod currently pins github.com/klauspost/compress v1.17.9 // indirect, but v1.18.0 (released Feb 19 2025) includes zstd deadlock fixes—bump the indirect require (or remove it to float) to adopt v1.18.0 and avoid reintroducing known issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test
- GitHub Check: Analyze (go)
🔇 Additional comments (3)
go.mod (3)
54-54: LGTM: da-codec bump aligns with the stated goal (zstd deadlock fix).The version bump to github.com/scroll-tech/da-codec v0.1.3-0.20250825071838-cddc263e5ef6 matches the PR objective to pull in the deadlock fix. No other deps were changed.
54-54: Module hygiene verified: go.sum includes the new da-codec v0.1.3-0.20250825071838-cddc263e5ef6 checksums (lines 399–400) and no vendor directory is present.
54-54: Verify no breaking changes across da-codec importers
Import sites forgithub.202132.xyz/scroll-tech/da-codec/encodingwere found in rollup/fees, da_syncer, rollup_sync_service, l1/reader, missing_header_fields, and core/rawdb. After bumping to v0.1.3-0.20250825071838-cddc263e5ef6, run:go mod tidy && go build ./... && go test ./...to confirm no compilation errors or test failures.
1. Purpose or design rationale of this PR
This PR aims to fix the zstd deadlock issue by updating the da-codec version.
da-codec pr: scroll-tech/da-codec#61
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit