-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add set code tx support #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n CodecFromConfig
…1 message hash from a given set of blocks
Conflicts: encoding/da.go encoding/interfaces.go go.mod go.sum
Co-authored-by: colin <[email protected]>
…MessageQueueHash -> postL1MessageQueueHash
WalkthroughThis update adds explicit handling for the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant EncodeFunc as convertTxDataToRLPEncoding
participant TxCreator as types.NewTx
Caller->>EncodeFunc: Call with txData (SetCodeTxType)
EncodeFunc->>TxCreator: Construct new transaction with converted fields
TxCreator-->>EncodeFunc: Return newly constructed transaction
EncodeFunc-->>Caller: Return encoded transaction
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thegaram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Let's merge after your 7702 PR was merged.
makes sense. |
Purpose or design rationale of this PR
This PR adds set code tx support in the
convertTxDataToRLPEncodingfunction.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
New Features
Chores