Skip to content

Conversation

jozic
Copy link
Collaborator

@jozic jozic commented Jan 6, 2024

  • mention some limitations
  • normalize headers
  • lineup badges to match other scoverage repos
  • mention that Scala version can be resolved from scala-library dependency

@jozic jozic force-pushed the mentioned-plugin-is-not-thread-safe branch from 9a7f1b1 to 99a89b8 Compare January 6, 2024 22:00
@jozic jozic changed the title Mention in README that the plugin is not thread-safe Update README Jan 6, 2024
@jozic jozic force-pushed the mentioned-plugin-is-not-thread-safe branch 3 times, most recently from 01ffcdf to 6657d62 Compare January 6, 2024 22:19
@jozic
Copy link
Collaborator Author

jozic commented Jan 6, 2024

@ckipp01 if you have a couple of minutes, I would appreciate extra pair of eyes here. But not critical, just README changes

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple grammar nits. Other than that LGTM

@jozic
Copy link
Collaborator Author

jozic commented Jan 7, 2024

Thanks @ckipp01, will apply your suggestions

@jozic jozic force-pushed the mentioned-plugin-is-not-thread-safe branch from 6657d62 to cb773ae Compare January 7, 2024 19:11
@jozic jozic merged commit dc7c6a6 into main Jan 7, 2024
@jozic jozic deleted the mentioned-plugin-is-not-thread-safe branch January 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants