-
Notifications
You must be signed in to change notification settings - Fork 328
Support PyTest container test suite for Python Container. #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This blocks: sclorg#768 Signed-off-by: Petr "Stone" Hracek <[email protected]>
This blocks: #768 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Also VARS.* variables are used during the migration. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Migration matrix is: `build_s2i_app` is fixture that takes `Path` test-app from `conftest.py` file. test_container_application.py tests all test-app directories. test_container_basics.py tests only basics w/o application. It also tests test_dockerfile and test_minimal_dockerfile Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
5866b10 to
cf7da90
Compare
|
Rebased against master. Let's run first round of tests. |
Testing Farm results
|
|
RHEL8 failures are caused by CDN errors: |
Add distgen generated files Signed-off-by: Petr "Stone" Hracek <[email protected]>
6a695bd to
e2004a5
Compare
|
[test][test-all] |
|
The new container-ci-suite was released. Let's re-test it. [test-all] |
|
Python failures are: C10S - PyTest - 3.12-minimal: It caused, I guess, main image should not be pulled. C10S - 3.12 should not be exists in quay.io/sclorg/python-312-c10s. RHEL10 does not exists. Fedora PyTest - 3.13 - test_container_basics.py::TestS2IPythonContainer::test_dockerfiles[Dockerfile.tpl] INFO:Image name to test: quay.io/fedora/python3-313:3.13 RHEL8 - 3.11 and RHEL9-PyTest-3.11 |
I don't understand this sentence, sorry. We have dockerfiles here for 3.12 and 3.12-minimal based on C10S.
The version of psycopg2-binary I see in the logs indicates that this test used django-ex branch 3.2.x and that's incorrect. New Pythons like 3.13 should use Django version/branch 4.2.x that has newer psycopg2-binary dependency and that new version provides wheels for Python 3.13.
I need more time to investigate the last one. I'm not able to reproduce locally so I need to build the container image first. |
This pull request migrates bash test suite
to container-ci-suite stored here: https://github.org/sclorg/container-ci-suite
Introduce PyTest suite migrated from test/run bash suite.
Migration matrix is:
build_s2i_appis fixture that takesPathtest-app fromconftest.pyfile.
test_container_application.py tests all test-app directories.
test_container_basics.py tests only basics w/o application.
It also tests test_dockerfile and test_minimal_dockerfile
Signed-off-by: Petr "Stone" Hracek [email protected]