Skip to content

Conversation

@ESadek-MO
Copy link
Contributor

Closes #185.

Corrected code in Iris tutorial Chapters 4 and 7. Units have now been hardcoded, which stops the demonstrative code throwing an error.
Should really include some explanation as to why the units need to be hard coded, but I'm not up to date enough as to write it myself; perhaps something to be added later.

@trexfeathers
Copy link
Contributor

SciTools/iris#3795 is what changed the behaviour. There's a lot more detail in items linked from there.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without running through the whole course myself, I will have to take your word for it that you've covered all cases! What you have changed makes sense.

I think it would be sensible to include a minor comment for the course participant, explaining that both the name and the units of the new coordinate must match those of the existing coordinates. It'd probably be too confusing to include any explanation about why the units are '1'.

@ESadek-MO
Copy link
Contributor Author

Have now done, added the following sentence into Chapter 4, where filling coordinates for merging is taught:
"Make sure both the name and units of the coordinates match the respective coordinate, so that Iris know they're the same and can be merged together"

@trexfeathers trexfeathers merged commit 3e1113d into scitools-classroom:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Out of date coordinate creation loop in: Iris Tutorial, Chapter 4

2 participants