⬆️ bump mypy to 1.18.1 and --ignore-disjoint-bases
#877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A quick benchmark shows that the speedup is 0.667x for mypy (no cache) and 0.76x for stubtests (so that's significantly faster). The primer run also took 4 minutes instead of the usual 6+ minutes to run. Mypy seems to have overtaken (based)pyright, as it now runs roughly 2s (~15%) faster on the scipy-stubs codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mypy.readthedocs.io/en/stable/changelog.html#mypy-1-18
This requires enabling the new
--ignore-disjoint-basesflag (python/mypy#19740). We'll enable it once PEP 800 is accepted, and it of course also requires pyright to support@disjoint_base.