Skip to content

Consolidate affine subspace and multiplicative coset methods into .shift() #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2020
Merged

Consolidate affine subspace and multiplicative coset methods into .shift() #24

merged 4 commits into from
Sep 9, 2020

Conversation

@pwang00
Copy link
Contributor

@pwang00 pwang00 commented Sep 9, 2020 •
edited
Loading

Addresses #18

ValarDragon
ValarDragon requested changes Sep 9, 2020
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing the refactor.

Just one minor comment about API consistency before merging!

@ValarDragon ValarDragon merged commit e23b714 into scipr-lab:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValarDragon ValarDragon ValarDragon requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pwang00 @ValarDragon