Refactor get_evaluation_domain into a separate file #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, building libfqfft on a system that already has libfqfft installed could result in cmake using the installed headers instead of ones from the version being built.
This resolves the cyclic dependencies between specific evaluation domains and evaluation_domain.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4.
After this change, all .hpp and .cpp files in libfqfft can be compiled individually without errors.
While implementing this, I also fixed a slight issue with the build system which could cause the wrong headers to be used at build time (see the relevant commit for more details).
libsnark pull request coming in a moment.