-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #32637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #32637
Conversation
|
Hmmm maybe an OpenML issue/glitch or mismatch with CircleCI locally cached file build log: I can not reproduce locally. |
|
Oh well there is a conflict now since another PR updating the lock-files was merged. I guess we can leave this open and the PR will be updated next Monday. |
a8866a9 to
7348077
Compare
|
Hmmm it looks like a thing in pytest 9.0 with raise unittest.case.SkipTest pytest-dev/pytest#13895. |
|
Looks like pytest-dev/pytest#13912 will restore this functionality. This would be nice for us. Maybe we should look into moving to using |
|
Given the number of projects that were affected, I guess it makes sense if pytest end up reverting the change. I guess we'll see what their plan is afterwards ... Note that some of our non-test code should not depend on def skip_test(msg):
pytest = sys.modules['pytest']
if pytest is not None:
pytest.skip(msg)
else:
raise SkipTest(msg) |
|
Good point about the "pytest isn't a requirement" angle. |
|
So are we waiting for another week for another round of the bot on this PR? |
I am reading disappointment in your comment @adrinjalali 😝. Pytest 9.0.1 has been released 2 hours ago which should fix it. I tried to re-trigger the update lock file workflow manually to see what this would do 🤞. |
|
So it updated all the other lock-file PR but not this one (i.e. the main CI one), apparently the latest pip and pip-tools version are not compatible 🙄 jazzband/pip-tools#2252. As many things, not hard to work-around but I'll stop here for today 😉. Details
|
|
You can use v7.5.2 now. |
Nice thanks for the heads-up 🙏! For completeness, we will also need that pytest 9.0.1 is available in conda-forge. The automated PR conda-forge/pytest-feedstock#194 was opened a few hours ago. |
|
Just double-checked and pytest 9.0.1 is available in conda-forge now, so we will see on Monday what happens with the lock-file update 🤞 |
Update lock files.
Note
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.