Skip to content

Conversation

@Foxglove144
Copy link
Contributor

@Foxglove144 Foxglove144 commented Jun 25, 2023

Reference Issue

N/A

What does this implement/fix? Explain your changes.

This pull request fixes an AttributeError in the Sequential object when using the predict_proba method. The Sequential class in TensorFlow does not have a predict_proba method. Instead, it has been deprecated in favour of the predict method, which directly returns the predicted class probabilities.

Any other comments?

N/A

@Foxglove144 Foxglove144 changed the title Fix AttributeError in Sequential object - predict_proba [MRG] Fix AttributeError in Sequential object - predict_proba Jun 25, 2023
@glemaitre glemaitre self-requested a review July 8, 2023 16:43
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a minimal version of tensorflow 2.4, I am keeping predict_proba until removal.

@glemaitre glemaitre merged commit f14033b into scikit-learn-contrib:master Jul 8, 2023
@glemaitre
Copy link
Member

Thanks @Foxglove144

@Foxglove144 Foxglove144 deleted the patch-1 branch July 8, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants