Skip to content

Conversation

@glemaitre
Copy link
Member

Make another round of improvement in the example using seaborn figure style and last scikit-learn helpers

@pep8speaks
Copy link

pep8speaks commented Feb 17, 2021

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:1: E402 module level import not at top of file
Line 33:1: E402 module level import not at top of file
Line 34:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 74:1: E402 module level import not at top of file
Line 75:1: E402 module level import not at top of file
Line 76:1: E402 module level import not at top of file
Line 77:1: E402 module level import not at top of file
Line 89:1: E402 module level import not at top of file
Line 99:1: E402 module level import not at top of file
Line 100:1: E402 module level import not at top of file

Line 29:1: E402 module level import not at top of file
Line 47:1: E402 module level import not at top of file
Line 64:1: E402 module level import not at top of file
Line 65:1: E402 module level import not at top of file
Line 66:1: E402 module level import not at top of file
Line 73:1: E402 module level import not at top of file
Line 91:1: E402 module level import not at top of file
Line 92:1: E402 module level import not at top of file

Line 18:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file
Line 32:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 73:1: E402 module level import not at top of file
Line 106:1: E402 module level import not at top of file
Line 107:1: E402 module level import not at top of file
Line 108:1: E402 module level import not at top of file
Line 109:1: E402 module level import not at top of file

Line 19:1: E402 module level import not at top of file
Line 32:1: E402 module level import not at top of file
Line 33:1: E402 module level import not at top of file
Line 55:1: E402 module level import not at top of file
Line 64:1: E402 module level import not at top of file
Line 65:1: E402 module level import not at top of file

Line 24:1: E402 module level import not at top of file
Line 43:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file
Line 55:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 78:1: E402 module level import not at top of file
Line 87:1: E402 module level import not at top of file

Line 19:1: E402 module level import not at top of file
Line 30:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file
Line 67:1: E402 module level import not at top of file
Line 68:1: E402 module level import not at top of file
Line 93:1: E402 module level import not at top of file

Line 16:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file
Line 28:1: E402 module level import not at top of file
Line 73:1: E402 module level import not at top of file
Line 100:1: E402 module level import not at top of file
Line 138:1: E402 module level import not at top of file
Line 139:1: E402 module level import not at top of file
Line 187:1: E402 module level import not at top of file
Line 188:1: E402 module level import not at top of file
Line 264:1: E402 module level import not at top of file
Line 294:1: E402 module level import not at top of file
Line 295:1: E402 module level import not at top of file
Line 327:1: E402 module level import not at top of file

Line 2:89: E501 line too long (95 > 88 characters)
Line 3:89: E501 line too long (106 > 88 characters)
Line 4:89: E501 line too long (99 > 88 characters)
Line 5:89: E501 line too long (94 > 88 characters)
Line 6:89: E501 line too long (114 > 88 characters)
Line 7:89: E501 line too long (95 > 88 characters)
Line 10:89: E501 line too long (90 > 88 characters)
Line 11:89: E501 line too long (91 > 88 characters)
Line 14:89: E501 line too long (89 > 88 characters)
Line 16:89: E501 line too long (100 > 88 characters)
Line 17:89: E501 line too long (90 > 88 characters)
Line 18:89: E501 line too long (101 > 88 characters)
Line 19:89: E501 line too long (98 > 88 characters)
Line 20:89: E501 line too long (92 > 88 characters)
Line 21:89: E501 line too long (90 > 88 characters)
Line 22:89: E501 line too long (105 > 88 characters)

Line 17:1: E402 module level import not at top of file
Line 24:1: E402 module level import not at top of file
Line 25:1: E402 module level import not at top of file
Line 38:1: E402 module level import not at top of file
Line 51:1: E402 module level import not at top of file

Line 22:1: E402 module level import not at top of file
Line 23:1: E402 module level import not at top of file
Line 44:1: E402 module level import not at top of file
Line 45:1: E402 module level import not at top of file
Line 46:1: E402 module level import not at top of file
Line 47:1: E402 module level import not at top of file
Line 60:1: E402 module level import not at top of file
Line 70:1: E402 module level import not at top of file

Line 16:1: E402 module level import not at top of file
Line 27:1: E402 module level import not at top of file
Line 72:1: E402 module level import not at top of file
Line 92:1: E402 module level import not at top of file
Line 105:1: E402 module level import not at top of file
Line 106:1: E402 module level import not at top of file
Line 107:1: E402 module level import not at top of file
Line 108:1: E402 module level import not at top of file
Line 142:1: E402 module level import not at top of file
Line 174:1: E402 module level import not at top of file
Line 210:1: E402 module level import not at top of file
Line 250:1: E402 module level import not at top of file
Line 282:1: E402 module level import not at top of file

Line 16:1: E402 module level import not at top of file
Line 42:1: E402 module level import not at top of file
Line 67:1: E402 module level import not at top of file
Line 68:1: E402 module level import not at top of file

Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 40:1: E402 module level import not at top of file
Line 93:1: E402 module level import not at top of file

Comment last updated at 2021-02-17 19:08:32 UTC

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #814 (e000d93) into master (2150e67) will decrease coverage by 3.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   98.59%   95.49%   -3.10%     
==========================================
  Files          93       93              
  Lines        6036     6035       -1     
  Branches      503      503              
==========================================
- Hits         5951     5763     -188     
- Misses         84      272     +188     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
imblearn/tensorflow/tests/test_generator.py 10.75% <0.00%> (-89.25%) ⬇️
imblearn/keras/tests/test_generator.py 7.93% <0.00%> (-84.13%) ⬇️
imblearn/tensorflow/_generator.py 35.48% <0.00%> (-64.52%) ⬇️
imblearn/keras/_generator.py 52.85% <0.00%> (-44.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2150e67...76e8507. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2021

This pull request fixes 1 alert when merging 77a9605 into 2150e67 - view on LGTM.com

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2021

This pull request fixes 1 alert when merging b63d336 into 2150e67 - view on LGTM.com

fixed alerts:

  • 1 for Variable defined multiple times

@glemaitre glemaitre merged commit 71b1e87 into scikit-learn-contrib:master Feb 17, 2021
@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2021

This pull request fixes 1 alert when merging 76e8507 into 2150e67 - view on LGTM.com

fixed alerts:

  • 1 for Variable defined multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants