Skip to content

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Feb 12, 2021

closes #792

Remove the smoothed_bootstrap param and only keep shrinkage to control the bootstrapping.

@pep8speaks
Copy link

pep8speaks commented Feb 12, 2021

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:1: E402 module level import not at top of file
Line 20:1: E402 module level import not at top of file
Line 33:1: E402 module level import not at top of file
Line 46:1: E402 module level import not at top of file

Comment last updated at 2021-02-12 14:19:56 UTC

@glemaitre
Copy link
Member Author

ping @chkoar Is it what you had in mind?

glemaitre and others added 2 commits February 12, 2021 13:30
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #794 (c921eb7) into master (3444430) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   98.55%   98.57%   +0.01%     
==========================================
  Files          87       87              
  Lines        5737     5740       +3     
  Branches      481      484       +3     
==========================================
+ Hits         5654     5658       +4     
+ Misses         82       81       -1     
  Partials        1        1              
Impacted Files Coverage Δ
imblearn/over_sampling/_random_over_sampler.py 100.00% <100.00%> (+1.49%) ⬆️
...rn/over_sampling/tests/test_random_over_sampler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3444430...c5149b5. Read the comment docs.

@glemaitre
Copy link
Member Author

@chkoar Is fine with you like this?

@chkoar
Copy link
Member

chkoar commented Feb 12, 2021

@chkoar Is fine with you like this?

I think yes.

@glemaitre glemaitre merged commit 1130324 into scikit-learn-contrib:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing ROSE class and add a shrinkage parameter to RandomOverSampler

3 participants