-
Notifications
You must be signed in to change notification settings - Fork 1.3k
FIX remove smoothed_bootstrap and use only shrinkage param #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX remove smoothed_bootstrap and use only shrinkage param #794
Conversation
|
Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-02-12 14:19:56 UTC |
|
ping @chkoar Is it what you had in mind? |
Co-authored-by: Christos Aridas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 98.55% 98.57% +0.01%
==========================================
Files 87 87
Lines 5737 5740 +3
Branches 481 484 +3
==========================================
+ Hits 5654 5658 +4
+ Misses 82 81 -1
Partials 1 1
Continue to review full report at Codecov.
|
|
@chkoar Is fine with you like this? |
Co-authored-by: Christos Aridas <[email protected]>
I think yes. |
closes #792
Remove the
smoothed_bootstrapparam and only keepshrinkageto control the bootstrapping.