[MNT] 👽 Drop np_version import
#745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop `from sklearn.utils.fixes import np_version` The specification for `np_version` changed in `scikit-learn`, leading to an error when tests ran. However, the test was whether the `numpy` version was less than `1.7.0`, which is outside the minimum version specified in `setup.py` and `requirements.txt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from sklearn.utils.fixes import np_versionWhat does this implement/fix? Explain your changes.
The specification for
np_versionchanged inscikit-learn,leading to an error when tests ran.
However, the test was whether the
numpyversion was less than1.7.0, which is outside the minimum version specified insetup.pyandrequirements.txtAny other comments?
Relevant PR in
scikit-learn: scikit-learn/scikit-learn#17670