Added histograms' comparison (and updated numpy.testing asserts to pytest.approx) #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gohil-jay
changed the title
henryiii
reviewed
Jun 28, 2022
| ) | ||
|
|
||
| import numpy as np | ||
| from pytest import approx |
Member
There was a problem hiding this comment.
We can't use pytest inside the library itself. There are tools for this like np.allclose. Also compare should return True/False, not errors / asserts. Let's move the changes to hist.py into a different PR, as that's not related to using approx in the tests. :)
Collaborator
Author
Collaborator
Author
|
The separate PR for the comparison is ready here in this branch (without pytest and true/false return): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.